cc-tweaked / CC-Tweaked

Just another ComputerCraft fork
https://tweaked.cc
891 stars 208 forks source link

Modems disappear when moved by create #948

Closed Schattengaenger closed 3 months ago

Schattengaenger commented 2 years ago

Minecraft Version

1.16.x

Version

1.98.2

Details

Hi,

I play a modpack and wanted to make an elevator programm with this mod using creates contraptions. I ran into a bug that only happens when it meets some unknown conditions but they are reproducable. I reportet the bug to the modpack's maker and he asked me to relay it to here and creates issue report system.

Below you will see a picture of a contraption able to reproduce the bug. The green stuff is super glue which create uses to attach blocks to a contraption. It enters the moving block state fine and displays everything right until it stops again where it delets the same modems every time while keeping others. I placed the modems all around (except top, but I believe the results would be similar there, too) and every place you can see the glue is a modem deleted, not even broken and on the floor, but vanishing from existance. The picture was taken in a singleplayer world with a forge profile ONLY containing create (, it's nessesary fly wheel mod) and CC: Tweaked as mods, but the results don't differ on a server either.

I hope you can help here, Sincerely, Manny 2021-10-28_00 55 12

latest.log

SirEdvin commented 2 years ago

I guess, you can try to move full-block modem

SquidDev commented 2 years ago

For reference, https://github.com/Creators-of-Create/Create/issues/2296 is the issue on the create side of things.

Schattengaenger commented 2 years ago

I guess, you can try to move full-block modem

Are you refering to the wired modem? If yes, than yeah it doens't break, but I need a wireless modem there and not a wired one. And while there are workarounds like mirroring the design in a way where it doesn't break in the direction I want to attach a modem to, It's still a bug that should be fixed eventually or do you disagree? Edit: some spelling.

Flexico commented 2 years ago

As workaround, I place the modem on either the top or bottom of the computer. They only disappear when on the side!

luigistyle commented 2 years ago

As workaround, I place the modem on either the top or bottom of the computer. They only disappear when on the side!

This doesn't seem to work for me. As soon as the contraption stops moving, the modem immediately disappears. I've tried placing it on the front, top, and bottom of the computer to no avail. Is there any update to this issue on either the CC or Create side of things?

EDIT: Putting it on the back works nvm lmao

getertext commented 1 year ago

This issue is not just for Create, it's for WorldEdit as well. It happens when an object is rotated, (With World edit it's with //rotate [angle] and with create is mechanical bearing) thus it might be a CCT issue or the other way around: they both have inconsistent rotation issues (which might be more likely), however, it's most likely to be a CCT side of issues due to strange metadata infrastructure (Proper: /setblock ~ ~ ~ minecraft:dispenser[facing=west], Improper: /setblock ~ ~ ~ jimsmod:laucher[direction=left, open=left]).

Plite7067 commented 3 months ago

Just made a datapack to fix this: https://github.com/Plite7067/CreateCCModemFix It adds the tag "#create:brittle" to them, which seems to fix the issue.

SquidDev commented 3 months ago

Thank you for looking into this, that was very helpful! I have added a similar fix to CC itself.