search

cc-tweaked / cc-restitched

Other
80 stars 31 forks source link

Fix #122 by simulating inventory transactions before execution. #127

Open toad-dev opened 2 years ago

toad-dev commented 2 years ago

The problem was that we were extracting up to the limit before we knew how many items the destination inventory could actually accept, and then we would fail to replace the remaining items back into the furnace output slot since it's protected from insertions. My fix is to simulate the transaction first, see how many items were successfully transferred, and only then mutate the inventories by that amount.

I would appreciate any reviews or testing on this because I feel like there are probably edge cases I haven't considered and I don't have a good world to test this on. I added some error logging in case it detects that items were lost.

There was also a similar issue with the turtle suck command that I applied the same sort of fix to, along with the error logging.

Merith-TK commented 1 year ago

is this mergable or is it stale?

Merith-TK commented 1 year ago

I... swear this was fixed?? is this still a problem??