search

cc-tweaked / cc-restitched

Other
80 stars 33 forks source link

Fix for #147 #151

Closed Giraaffes closed 9 months ago

Giraaffes commented 9 months ago

As mentioned in #147, there's a huge issue in singleplayer on 1.18.2 v1.100.8 where chunks with computers in them won't save, unless the player stays on the menu screen for long enough. I assume there's some good reason that the way it's fixed in c09735c can't or shouldn't be backported, but the issue pretty much makes this version of the mod unplayable.

Checking if the server still exists before broadcasting a computer delete message fixes it (the same way it's done in UpgradeSpeakerPeripheral)

Merith-TK commented 9 months ago

Make the checks succeed and get atleast another person verify it works and I will merge,

(if it's a bug with the checks let me know and I will look into it as I am at work at time of writing. This)

Giraaffes commented 9 months ago

I've had my friend verify that this also fixes the issue on their computer. As for the checks I've got no clue. It says that "license violations were found" in a lot of classes during the build, but all I've really done is add 2 lines of code.

Merith-TK commented 9 months ago

@SquidDev wasnt this build thing supposed to be fixed at one point a while ago?

Merith-TK commented 9 months ago

will make "release" later after work, I dont have my 2FA key with me so I cant make sure the Curseforge page will update properly

Giraaffes commented 9 months ago

Are you going to make a release? Not to rush you or anything, just making sure it hasn't been forgotten.

Merith-TK commented 9 months ago

Sorry, night-shift at walmart not conducive to memory

Giraaffes commented 9 months ago

No problem

wallth144 commented 7 months ago

Hi, any updates on this?