search

cc-tweaked / cc-restitched

Other
80 stars 31 forks source link

Inventory peripherals don't support transfer api #88

Open MattiDragon opened 2 years ago

MattiDragon commented 2 years ago

If you try to interact with any block that uses the fabric transfer api using the inventory peripheral it simply won't be detected. Many mods have started exclusively using this api for their inventories and such compatibility will only get worse over time if this isn't fixed. I don't see logs being useful and for reference I'm using minecraft 1.18.2 with cc-restitched 1.100.5.

Merith-TK commented 2 years ago

Will look into it, been a while since I personally took a look at the code.

As always, PR's are always welcome

toad-dev commented 2 years ago

Can you give an example of some blocks that you think should work but don't? It would be helpful.

MattiDragon commented 2 years ago

You can test it on many mods, but an easy one would be my drawers mod. Hoppers can interact with them due to a fapi patch (and so can other transfer mods), but cc can't.

leo60228 commented 2 years ago

This seems to also affect Create belts, but that might be a separate issue?

Merith-TK commented 2 years ago

try with this mod https://www.curseforge.com/minecraft/mc-mods/unlimitedperipheralworks

this is currently mod that adds support for Transfer API (functions kinda like the Fluid API according to documentation)

unfortunately we cannot properly add support for the Transfer API as of this moment as it will require basically an complete rewrite of the inventory code to my knowlede

luiz00martins commented 1 year ago

Can you give an example of some blocks that you think should work but don't? It would be helpful.

Some other examples of this are the Modern Industrialization Barrels & Machines, and the DankStorage Danks.

You can test this on AOF6. None of them will connect to the Modem.

MattiDragon commented 1 year ago

Transfer api recently added an optional slot system. Would it be possible to support that?