search

cca-io / rescript-mui

ReScript bindings for MUI
MIT License
255 stars 52 forks source link

Fab component is missing ButtonBase props #208

Closed DrMorbid closed 10 months ago

DrMorbid commented 10 months ago

Hello, onClick cannot be used as a prop for the Fab component. When I hardcode it to the transpiled .js file, everything works. When you look at the doc page, you can find a sentence:

Props of the ButtonBase component are also available.

fhammerschmidt commented 10 months ago

Thanks for reporting! I fixed it here: https://github.com/cca-io/rescript-mui/commit/872dc23ac849ac2234656f6b7e90c33d568a007f and also published a new version.

DrMorbid commented 10 months ago

Thanks a lot for such a quick fix! Not sure it's completely correct though. It seems that onClick is in type clickablePropsWithOnClick and not clickableProps.

fhammerschmidt commented 10 months ago

Argh! I set up a trap for myself here. Fixed it now and published another version. Sorry.