It seems like many students, while their prox numbers haven't changed across multiple prox reports, still don't have them in Koha. But the way the patch_prox_num script works is, to minimize HTTP requests, we just check against the most recent prox report and the last one we have on disk and only consider it a "changed" number if there's a difference there. There seem to be many situations where a student record is created or otherwise update such that their prox falls out of date but the script doesn't catch the change.
Paul sent me a couple example students to work with today. One still has their old cardnumber (not prox) so that should be a good test. We need the script to actually pull the Koha record, check for a prox num difference, and make an update if so. We can get rid of the code that compares a past prox report to the current one.
It seems like many students, while their prox numbers haven't changed across multiple prox reports, still don't have them in Koha. But the way the patch_prox_num script works is, to minimize HTTP requests, we just check against the most recent prox report and the last one we have on disk and only consider it a "changed" number if there's a difference there. There seem to be many situations where a student record is created or otherwise update such that their prox falls out of date but the script doesn't catch the change.
Paul sent me a couple example students to work with today. One still has their old cardnumber (not prox) so that should be a good test. We need the script to actually pull the Koha record, check for a prox num difference, and make an update if so. We can get rid of the code that compares a past prox report to the current one.