cca / koha_snippets

code to be pasted into Koha's admin side
https://library.cca.edu
Other
4 stars 0 forks source link

broken holdings table for American Visions #45

Closed phette23 closed 9 months ago

phette23 commented 9 months ago

https://library.cca.edu/cgi-bin/koha/opac-detail.pl?biblionumber=22479

Holdings don't display. There are many hidden items on this record, perhaps that's related? Try disabling whatever customizations affect the holdings table to see if we are causing this problem ourselves. If not, probably need to ask ByWater and search Koha bugs to figure out what might be wrong.

phette23 commented 9 months ago

The problem does appear to be in catalog-js/holdings-table-filter.js which, if it's deleted from our OpacUserJS, causes the holdings table to appear again. I'm not sure why this particular table breaks it. Some of the parameters copied from Koha's source code appear to have changed, but updating them also does not fix the issue.

So this is related to #39 and commit 54deb14a.

phette23 commented 9 months ago

Running the current holdings-table-filter.js on a fully loaded page works without breaking the table. So perhaps there is a race condition where the table is in the process of being built while our script destroys and recreates it. We need to find a way to wait for the datatable to be complete before rebuilding it.