search

ccagc / QDNAseq

QDNAseq package for Bioconductor
47 stars 27 forks source link

CODE: if() conditions comparing class() to string #109

Closed HenrikBengtsson closed 2 years ago

HenrikBengtsson commented 2 years ago

R CMD check --as-cran gives:

** checking R code for possible problems (20s)
   Found if() conditions comparing class() to string:
   File ‘QDNAseq/R/QDNAseqCopyNumbers-accessors.R’: if (class(bins) == "data.frame") ...
   File ‘QDNAseq/R/QDNAseqCopyNumbers-accessors.R’: if (class(phenodata) == "data.frame") ...
   File ‘QDNAseq/R/QDNAseqReadCounts-accessors.R’: if (class(bins) == "data.frame") ...
   File ‘QDNAseq/R/QDNAseqReadCounts-accessors.R’: if (class(phenodata) == "data.frame") ...
   File ‘QDNAseq/R/binReadCounts.R’: if (class(bins) == "data.frame") ...
   File ‘QDNAseq/R/binReadCounts.R’: if (class(bins) == "data.frame") ...
   File ‘QDNAseq/R/binReadCounts.R’: if (class(phenodata) == "data.frame") ...
   File ‘QDNAseq/R/highlightFilters.R’: if (class(object) == "QDNAseqReadCounts") ...
   Use inherits() (or maybe is()) instead.