search

ccagc / QDNAseq

QDNAseq package for Bioconductor
47 stars 27 forks source link

PERFORMANCE: Unnecessary coercions #71

Closed HenrikBengtsson closed 5 years ago

HenrikBengtsson commented 5 years ago

For example,

https://github.com/ccagc/QDNAseq/blob/e0afdde02373087d1444b9dde7d0b10bcdbe4b21/R/exportBins.R#L207-L219

should probably be:

    svtype <- rep(NA_character_, length(chr)) 
    svlen <- rep(NA_real_, length(chr)) 
    gt <- rep(NA_character_, length(chr))