ccagml / leetcode-extension

Solved LeetCode problem in VS Code added some new features
https://marketplace.visualstudio.com/items?itemName=ccagml.vscode-leetcode-problem-rating
MIT License
273 stars 28 forks source link

fix windows build bug #262

Closed sgrtye closed 11 months ago

sgrtye commented 11 months ago

When building the extension on Windows with WSL installed, the npm 'master' branch was detected instead of 'windows_master', resulting in an error.

'The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command rm -rf out" terminated with exit code: 1.'

By adding OS-based detection, the extension can be built correctly across all OS systems.

PS: Did not check the branching logic in .vscode/launch.json, we might be able to ditch the 'windows_master' branch altogether by adding OS-based conditions to all tasks. (Currently, the only difference is using 'rm' or 'Remove-item', which can be done inline relatively easily using only OS-based conditions)