Wrapped in UMD pattern for AMD support

ccampbell / gator

Event delegation in Javascript

http://craig.is/riding/gators

492 stars 46 forks source link

Wrapped in UMD pattern for AMD support #9

Closed asbjornenge closed 10 years ago

asbjornenge commented 10 years ago

Wrapped Gator as a UMD module - https://github.com/umdjs/umd - for AMD support. :package: Love the lib :+1:

lazd commented 10 years ago

@asbjornenge, I know this is a very old PR, but you can always do a git reset HEAD~1 then git push --force to remove the unwanted commit from the branch you sent the PR from.

asbjornenge commented 10 years ago

@lazd thanks for the tip :+1: I've learnt a lot about git since this PR :monkey_face:

lazd commented 10 years ago

Yeah! That was a long time ago :)

If the library were to accept the change, I would expect it to be compatible with all the other module types as well (AMD, CommonJS/Node.js, UMD, ECMAScript 6), so I'd say closing this pull request and adding a note about shimming for use in Browserify/RequireJS is the best option.

asbjornenge commented 10 years ago

:+1: