ccampbell / rainbow

Simple syntax highlighting library written in javascript
http://rainbowco.de
Apache License 2.0
3.3k stars 465 forks source link

Change isNode check #238

Closed pamelafox closed 6 years ago

pamelafox commented 6 years ago

The isNode function is problematic, because it no longer works. (Discussed in https://github.com/ccampbell/rainbow/issues/213)

Changing it to return false works for our browser use case, and that's what this diff does.

I could alternatively:

pamelafox commented 6 years ago

Oops, sorry, I meant to open this on the Khan fork. Obviously the real version needs a better fix than my bandaid. Carry on!