search

ccann / gregor

Lightweight Clojure bindings for Apache Kafka
Eclipse Public License 1.0
23 stars 5 forks source link

Replace ZkUtils, AdminUtils with Kafka AdminClient #7

Open fr33m0nk opened 4 years ago

fr33m0nk commented 4 years ago

Hi,

ZkUtils, AdminUtils were marked for Deprecation since the introduction of Kafka v2.0.0 It would be great if the dependency on ZkUtils, AdminUtils can be looked at as Kafka v2.4.1 removes these deprecated classes, which breaks gregor.

I can raise a PR for this issue though

fr33m0nk commented 4 years ago

I have raised the pull request with changes. It would be very helpful if this PR is looked at.

Thanks

fr33m0nk commented 4 years ago

On a deeper level of testing, it looks the changes require more rework. I will raise a PR later this weekend

luhhujbb commented 3 years ago

My pull request #9 should fix this issue.

ccann commented 3 years ago

Thanks folks, I will look at this ASAP