ccao-data / actions

GitHub Actions for CCAO Data projects
0 stars 0 forks source link

Remove branch delete event handling from `build-and-run-batch-job` #18

Closed jeancochrane closed 8 months ago

jeancochrane commented 8 months ago

This PR removes the handling for GitHub branch deletion events in build-and-run-batch-job / cleanup that was introduced in https://github.com/ccao-data/actions/pull/17.

Our reason for reverting this change is that the branch deletion handling logic is proving to be tricky to get right, and it can only be debugged when the code is on the repo main branch due to limitations in the delete event. We're plan to remove the logic for now and revisit it once we complete the design for https://github.com/ccao-data/actions/issues/16; in the meantime, we've decided to put up PRs for all branches that we use to run Batch jobs in https://github.com/ccao-data/model-res-avm, such that closing the PRs runs build-and-run-batch-job / cleanup.