ccao-data / actions

GitHub Actions for CCAO Data projects
0 stars 0 forks source link

Make sure that resources in `build-and-run-batch-job` follow Batch naming rules #9

Closed jeancochrane closed 6 months ago

jeancochrane commented 6 months ago

This PR updates the Terraform logic for the build-and-run-batch-job workflow to ensure that Batch resource names meet Batch naming requirements. In particular, this workflow run revealed that we need to convert periods into valid characters, and we also should truncate the name after 128 characters to be safe.

See here for a test PR using these changes: https://github.com/ccao-data/model-res-avm The branch name contains periods and is long enough that it gets truncated before being applied as a Terraform resource name. Note that the workflow run technically failed, but that's only because I cancelled it after confirming that the Terraform config got applied as expected.

This PR also closes https://github.com/ccao-data/actions/issues/8.