ccao-data / data-architecture

Codebase for CCAO data infrastructure construction and management
https://ccao-data.github.io/data-architecture/
6 stars 4 forks source link

Clean up and format dbt test workbook #298

Closed jeancochrane closed 8 months ago

jeancochrane commented 8 months ago

This PR makes a number of quality-of-life improvements to the dbt test workbook that gets output by the .github/scripts/format_dbt_test_failures.py script. It is the basis of the workbook that was sent over to the rest of the internal stakeholders for review.

Improvements include:

Changes were tested by generating the workbook with the following commands run in the dbt/ subdirectory:

dbt test --select test_qc_* --exclude test_qc_exclude_from_workbook --store-failures
python3 ../.github/scripts/format_dbt_test_failures.py

Closes https://github.com/ccao-data/data-architecture/issues/288.

jeancochrane commented 8 months ago

I left some responses to your questions @dfsnow, this is probably worth one more look just to make sure we're on the same page!

dfsnow commented 8 months ago

I left some responses to your questions @dfsnow, this is probably worth one more look just to make sure we're on the same page!

I think we're set to go! Let's merge