As of this PR our condo characteristics filling is rather naive - we only have one set of characteristics for any given condo so we just join these characteristics on condos by PIN rather than PIN and year then back and forward fill.
This will cause problems and create duplicate PINs within years with different characteristics if we ever collect multiple years worth of characteristics data for a given triad or if we switch to iasWorld and roll characteristics forward each year in whatever table contains them.
Let's revisit this strategy once we have a better idea of the long term status of condo characteristics collection and storage.
As of this PR our condo characteristics filling is rather naive - we only have one set of characteristics for any given condo so we just join these characteristics on condos by PIN rather than PIN and year then back and forward fill.
This will cause problems and create duplicate PINs within years with different characteristics if we ever collect multiple years worth of characteristics data for a given triad or if we switch to iasWorld and roll characteristics forward each year in whatever table contains them.
Let's revisit this strategy once we have a better idea of the long term status of condo characteristics collection and storage.