Closed jeancochrane closed 3 months ago
~Oops, I marked this PR as ready for review before running the final check (generating the output workbook and making sure it still looks correct). Doing that now; no need to review just yet.~ Done, ready for review!
Most of our generic dbt test functions support an
additional_select_columns
parameter that instructs the test to select additional columns from the base table for use in test failure reporting. There are a few problems with the current implementation, however:additional_select_columns
separatelyexpression_is_true
test uses the older nameselect_columns
for the same parameterunique_combination_of_columns
andres_class_matches_pardat
both permit an object structure for aliasing and aggregation, but this structure is not supported in other generics, and the two generics that do support it implement it differentlyThis PR represents an attempt to resolve these issues and standardize our implementation of
additional_select_columns
attributes using a new macroformat_additional_select_columns
.Closes https://github.com/ccao-data/data-architecture/issues/330.