ccao-data / data-architecture

Codebase for CCAO data infrastructure construction and management
https://ccao-data.github.io/data-architecture/
5 stars 3 forks source link

Refactor `additional_select_columns` dbt test params to support more configurable naming and aggregation #339

Closed jeancochrane closed 3 months ago

jeancochrane commented 3 months ago

Most of our generic dbt test functions support an additional_select_columns parameter that instructs the test to select additional columns from the base table for use in test failure reporting. There are a few problems with the current implementation, however:

This PR represents an attempt to resolve these issues and standardize our implementation of additional_select_columns attributes using a new macro format_additional_select_columns.

Closes https://github.com/ccao-data/data-architecture/issues/330.

jeancochrane commented 3 months ago

~Oops, I marked this PR as ready for review before running the final check (generating the output workbook and making sure it still looks correct). Doing that now; no need to review just yet.~ Done, ready for review!