search

ccao-data / data-architecture

Codebase for CCAO data infrastructure construction and management
https://ccao-data.github.io/data-architecture/
5 stars 3 forks source link

Add iasWorld colnames to descriptions of tests in `qc` and `dweldat` #355

Closed jeancochrane closed 3 months ago

jeancochrane commented 3 months ago

This PR is a fast follow on https://github.com/ccao-data/data-architecture/pull/351 to make the meta.description attributes easier to read for tests in the qc and dweldat models, as well as a few related tests on the comdat, and oby models. The more opaque fields on these models now include a hint indicating the iasWorld name of the field in the meta.description attribute, which gets templated into the dbt test failure workbook. This should make it a little bit easier for workbook users to act on problems in iasWorld when they are reported in the failure workbook.

Note that there were a few columns that I wanted to annotate with iasWorld fieldnames, but which I was unable to find in iasworld:

Let me know if you have any insight into the meaning of these columns, and otherwise I'll just leave the raw column name alone in meta.description.

Closes https://github.com/ccao-data/data-architecture/issues/354.

jeancochrane commented 3 months ago

I think this could use another look since b57d1a1 makes a pretty substantial change!