Open dfsnow opened 5 months ago
[Suggestion, non-blocking] Yup, I support updating the row_values_match_after_join to make this easier. Here's how we do it in the res_class_matches_pardat generic: https://github.com/ccao-data/data-architecture/blob/e313087555fa3afebd91e16445640947175a1570/dbt/tests/generic/test_res_class_matches_pardat.sql#L50-L78 I'm fine with breaking this out into its own issue to avoid blocking this PR.
[Suggestion, non-blocking] Yup, I support updating the row_values_match_after_join to make this easier. Here's how we do it in the res_class_matches_pardat generic:
row_values_match_after_join
res_class_matches_pardat
https://github.com/ccao-data/data-architecture/blob/e313087555fa3afebd91e16445640947175a1570/dbt/tests/generic/test_res_class_matches_pardat.sql#L50-L78
I'm fine with breaking this out into its own issue to avoid blocking this PR.
_Originally posted by @jeancochrane in https://github.com/ccao-data/data-architecture/pull/400#discussion_r1573025466_
_Originally posted by @jeancochrane in https://github.com/ccao-data/data-architecture/pull/400#discussion_r1573025466_