Closed jeancochrane closed 1 month ago
This PR makes a few tweaks to dweldat and pardat.tieback tests based on feedback from Valuations:
dweldat
pardat.tieback
attic
3: None
bsmt
2: Slab
212
pardat
Closes https://github.com/ccao-data/data-architecture/issues/433.
This PR makes a few tweaks to
dweldat
andpardat.tieback
tests based on feedback from Valuations:dweldat
attic finish to filter out cases whereattic
is3: None
dweldat
basement finish to filter out cases wherebsmt
is2: Slab
dweldat
tests for number of commercial units to only allow nulls or 0 when class is not212
, and disallow these values when class is212
pardat
test to ensure hyphens are not in tieback from workbook, since Valuations can't act on itCloses https://github.com/ccao-data/data-architecture/issues/433.