Closed wrridgeway closed 1 month ago
This query should return nothing if our additions didn't change the view:
WITH old AS (
SELECT
*
FROM reporting.vw_pin_township_class
),
new AS (
SELECT
pin,
year,
triad_name,
triad_code,
township_name,
township_code,
nbhd,
municipality_name,
class,
major_class,
property_group,
reassessment_year
FROM "z_ci_424_identify_ahsap_properties_and_update_reporting_views_reporting".vw_pin_township_class
)
SELECT * FROM old
EXCEPT
SELECT * FROM new
And that's what it does.
The only thing to test here other than that the changes didn't alter the structure of vw_pin_township_class
is the ahsap
column. There really isn't a great way to do that other than to compare against the list of AHSAP parcels on the intranet. I did that and while there's a decent amount of overlap, there are differences. I sent PINs from the intranet not captured by this iasWorld logic to Brian so he can investigate. For now, this is as good as our indicator is going to get and we can update it once Brian gets back to us with any new information.
This PR adds one new column to
reportingvw_pin_township_class
, an AHSAP indicator based on values from a number of different iasWorld fields: