Closed jeancochrane closed 1 month ago
As discussed in https://github.com/ccao-data/aws-infrastructure/pull/26#discussion_r1609011282, there's currently an edge case in our dbt model dependency deployment pipeline that could bite us in the future. The problem is the combination of these three aspects of the pipeline:
build-and-test-dbt
build-daily-dbt-models
As such, it's possible for build-daily-dbt-models to run without model dependencies existing, if they happen to have expired before it runs.
This PR fixes this edge case by updating build-daily-dbt-models to deploy model dependencies in the same way that build-and-test-dbt does.
I tested this PR by manually dispatching build-daily-dbt-models from this branch. (I ran the action just long enough to confirm that the deployment step succeeds, but cancelled it at that point, so the workflow appears to have failed.) Here's evidence that the deployment step succeeds: https://github.com/ccao-data/data-architecture/actions/runs/9193740823/job/25286017600#step:5:28
As discussed in https://github.com/ccao-data/aws-infrastructure/pull/26#discussion_r1609011282, there's currently an edge case in our dbt model dependency deployment pipeline that could bite us in the future. The problem is the combination of these three aspects of the pipeline:
build-and-test-dbt
workflow, which runs on PRs being merged to the main branchbuild-daily-dbt-models
workflow, which is scheduled to run once a dayAs such, it's possible for
build-daily-dbt-models
to run without model dependencies existing, if they happen to have expired before it runs.This PR fixes this edge case by updating
build-daily-dbt-models
to deploy model dependencies in the same way thatbuild-and-test-dbt
does.I tested this PR by manually dispatching
build-daily-dbt-models
from this branch. (I ran the action just long enough to confirm that the deployment step succeeds, but cancelled it at that point, so the workflow appears to have failed.) Here's evidence that the deployment step succeeds: https://github.com/ccao-data/data-architecture/actions/runs/9193740823/job/25286017600#step:5:28