ccao-data / data-architecture

Codebase for CCAO data infrastructure construction and management
https://ccao-data.github.io/data-architecture/
5 stars 3 forks source link

Refactor nonlivable chars test into either a unit test or a QC test #515

Open jeancochrane opened 2 weeks ago

jeancochrane commented 2 weeks ago

The test default_vw_pin_condo_char_nonlivable_no_chars is currently sort of a unit test and sort of a data test, testing data that isn't in iasWorld and also testing our transformation at the same time. This causes problems when an error is introduced, because it's not actionable but also ends up failing any workflows that modify or rebuild the vw_pin_condo_char table (see here for an example).

We should refactor this test so that it is either a unit test or a QC test, or more likely split it out into two separate tests. The goal is to introduce one or more tests for the field that are actionable if they fail.