Maintain feature parity with `model-res-avm`

ccao-data / model-condo-avm

Automated valuation model for all class 299 and 399 residential condominiums in Cook County

GNU Affero General Public License v3.0

5 stars 2 forks source link

Maintain feature parity with `model-res-avm` #19

Closed wrridgeway closed 9 months ago

wrridgeway commented 11 months ago

See https://github.com/ccao-data/model-condo-avm/issues/18.

This PR is rather extensive. It primarily refactors the pipeline and surrounding infrastructure in order to bring it in line with the res model pipeline.

It's not up-to-date with the last week or so of work in the res pipeline, but this PR is getting pretty unwieldy.

wrridgeway commented 10 months ago

Current issues:

KNN isn't being tuned
~~char_building_sf removed from linear model transformations/interaction terms~~ this feature was getting kicked out of the linear model recipe by step_nzv since so many values are just the imputed median...
assessment_data_merged in 02-assess has unexpected many-to-many join