search

ccao-data / model-res-avm

Automated valuation model for all class 200 residential properties in Cook County (except vacant land and condos)
GNU Affero General Public License v3.0
26 stars 5 forks source link

Update `interpret` pipeline stage to optionally generate leaf node comps for all properties #106

Closed jeancochrane closed 8 months ago

jeancochrane commented 9 months ago

This PR updates the pipeline to optionally generate comps for all properties using leaf node assignments and upload them to S3 based on a new comp_enable param. This experimental approach to comp calculation is explained in this lightsnip vignette and uses the fastest algorithm described in this blog post.

The approach in this PR depends on changes in a companion branch of ccao-data/lightnsip. Before this branch gets merged, that branch should be merged into the main branch of lightsnip and the renv lockfile in this repo should be updated to point back to the main lightsnip branch.

Connects https://github.com/ccao-data/model-res-avm/issues/41.

jeancochrane commented 8 months ago

@dfsnow The changes in response to your comments are officially working as of 2024-01-26-optimistic-eric complete, so I think this is ready for a final pass!

dfsnow commented 8 months ago

Alright we've got a full run with (seemingly) all bugs worked out. Final log output here. Gonna go ahead and merge!