search

ccaprani / pycba

Python Continuous Beam Analysis
https://ccaprani.github.io/pycba/
Apache License 2.0
64 stars 29 forks source link

Sum of envelopes + example #93

Open RoccoRaimo opened 6 months ago

RoccoRaimo commented 6 months ago

Hi @ccaprani! I've implemented the new method in class Envelopes to sum multiple envelopes, as described in #92, and included the example n.5 to show a possible usage scenario.

Let me know if everything is straight and clear! Thanks.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.64%. Comparing base (9322c65) to head (66363c2). Report is 17 commits behind head on main.

Files Patch % Lines
src/pycba/results.py 7.14% 13 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== + Coverage 79.97% 82.64% +2.67% ========================================== Files 13 13 Lines 1368 1596 +228 ========================================== + Hits 1094 1319 +225 - Misses 274 277 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RoccoRaimo commented 6 months ago

At the end of the example in the notebook I inserted a numerical control of the results between a "manual" sum of the results and the "automatic" one that comes with the use of the new function. Don't know if it makes sense to create a separate test. Let me know once you'll look up at the notebook :)

RoccoRaimo commented 3 months ago

Hi Colin! Have you had a look at the notebook with the example on it?