search

ccarney16 / pterodactyl-containers

Pterodactyl Panel within a docker container
230 stars 78 forks source link

Fix Container Startup Problem #132

Closed Ferks-FK closed 2 years ago

Ferks-FK commented 2 years ago

Currently the base file generated by the script contains a small problem with container initialization. It is not a serious problem, but a fix for better container performance, at least for its first startup.

Current behavior:

When doing the first container initialization, mysql is started along with the cache, but before mysql completes its initialization, the panel starts to be initialized. This leads to a pile of unsuccessful attempts to connect to mysql, and in some of my tests, the panel could not connect at all, requiring a new startup attempt.

New Behavior:

This pull request makes some changes so that the panel container starts only when the mysql container is started, and accepting connections. This will ensure that all containers can boot correctly.

Just one example of the problem: #131

ccarney16 commented 2 years ago

Ive tried this before, however one of the large glaring issues with it is that is only affects how compose creates and starts containers, not during runtime or restarts. Its why I opted to use a script inside the panel container to wait for mysql to start up. I can take a look further into this but I have not had time to look at new/current issues.

Ferks-FK commented 2 years ago

Ive tried this before, however one of the large glaring issues with it is that is only affects how compose creates and starts containers, not during runtime or restarts. Its why I opted to use a script inside the panel container to wait for mysql to start up. I can take a look further into this but I have not had time to look at new/current issues.

Yes, with the above modifications, the panel waits for mysql to start up completely. Fixes part of the problem.