ccarney16 / pterodactyl-containers

Pterodactyl Panel within a docker container
234 stars 79 forks source link

pterodactyl daemon 1.0.1 not handeling timezones correctly #79

Closed lopaker closed 4 years ago

lopaker commented 4 years ago

Hey there,

I am pretty new to this bug reporting stuff so please don't be to harsh on me. I just realised a problem with the new 1.0.1 Update you posted on your Daemon.

I am located in Germany and therefore use "Europe/Berlin" as my timezone

Pre-start: Checking for Daemon configuration...
Pre-start: Config found
Starting Pterodactyl Daemon v1.0.1...

                     ____
__ Pterodactyl _____/___/_______ _______ ______
\_____\    \/\/    /   /       /  __   /   ___/
   \___\          /   /   /   /  /_/  /___   /
        \___/\___/___/___/___/___    /______/
                            /_______/ v1.0.1

Copyright © 2018 - 2020 Dane Everitt & Contributors

Website:  https://pterodactyl.io
 Source:  https://github.com/pterodactyl/wings
License:  https://github.com/pterodactyl/wings/blob/develop/LICENSE

This software is made available under the terms of the MIT license.
The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

 INFO: [Oct 27 14:47:47.709] writing log files to disk path=/var/log/pterodactyl/wings.log
 INFO: [Oct 27 14:47:47.709] loading configuration from path path=/etc/pterodactyl/config.yml
FATAL: [Oct 27 14:47:47.709] failed to detect system timezone or use supplied configuration value error=the supplied timezone Europe/Berlin is invalid: unknown time zone Europe/Berlin

Stacktrace:
github.com/pterodactyl/wings/config.(*SystemConfiguration).ConfigureTimezone
    /wings/config/config_system.go:224
github.com/pterodactyl/wings/cmd.rootCmdRun
    /wings/cmd/root.go:135
github.com/spf13/cobra.(*Command).execute
    /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:846
github.com/spf13/cobra.(*Command).ExecuteC
    /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
    /go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887

That is what happens when using this time zone. Running the same container with the same config in v1.0.0 was totally fine.

Thats why you never use the tag :latest 😄

lopaker commented 4 years ago

I justed saw your commit of removing the time zone and making it a environment variable. my bad ;)