ccarruitero / makemehapi

Self guided workshops to teach you about hapi.
https://www.npmjs.com/package/makemehapi
Other
479 stars 107 forks source link

the "validation" assignment tests whether "/" is a 404, despite not being an assignment requirement #130

Open Pomax opened 9 years ago

Pomax commented 9 years ago

The validation assignment currently fails if the / route serves actual content, despite this not being relevant to the assignment of making a /chickens/{breed} route. There is no good reason for this failure: especially if people are extending their program as they run through the assignments, the / route will still contain the ROT13 exercise output. Which should be fine.

dylancwood commented 9 years ago

I've submitted a PR (#141) that updates the url used to run/verify this exercise.

jackmcmorrow commented 9 years ago

Following code passes this assingment:

Hapi = require('hapi');
var server = new Hapi.Server();

server.connection({
    host: 'localhost',
    port: Number(process.argv[2] || 8080)
})

server.start();