search

ccarruitero / makemehapi

Self guided workshops to teach you about hapi.
https://www.npmjs.com/package/makemehapi
Other
480 stars 107 forks source link

Add `.gitattributes` file #188

Closed akihito-takeuchi closed 7 years ago

akihito-takeuchi commented 7 years ago

When I run the command 'makemehapi', following error message was shown.

env: node\r: No such file or directory

Looks like the line ending of 'makemehapi.js' is DOS. Is that possible to change the line ending to Linux one?

alanbhamilton commented 7 years ago

I'm seeing this as well on MacOS 10.10. It affects both the 5.1.0 and 5.2.0 releases, but 5.0.1 works just fine.

alanbhamilton commented 7 years ago

This article from Github Help gives more information on this problem.

Perhaps adding a .gitattributes file to this repo?

https://github.com/hapijs/hapi/pull/719/commits/9d46d7f2324426619d15ccb783ff59eaa211b324

fiveisprime commented 7 years ago

I'll add the .gitattributes

I can't reproduce this though - I'm on macOS 10.12.1 with: node@7.2.1, npm@3.10.10, makemehapi@5.2.1

Everything is working correctly.

fiveisprime commented 7 years ago

Okay, never mind, 5.1.0 and 5.2.0 are borked - latest/5.2.1 is okay so I guess the last set of changes fixed the issue. I'll still get .gitattributes added though.

iwasrobbed commented 7 years ago

I'm getting this today even with the .gitattributes file in 5.2.1 and I don't see any file changes when following the Github instructions