ccatterina / plasmusic-toolbar

KDE Plasma widget that shows currently playing song information and provide playback controls.
GNU General Public License v3.0
89 stars 7 forks source link

Colors from album cover #120

Closed luisbocanegra closed 2 weeks ago

luisbocanegra commented 4 months ago

I have been thinking of adding this feature for some time, today I was experimenting and came up what you see below (still wip)

Is this something you would like to have?

If it were to be added:

append-2024-07-22-200105

ccatterina commented 4 months ago

Wow, what a really cool feature! :star_struck:

Should allow to enable/disable the feature, I think it could be distracting having the colors changing all the time for some users

Yeah, and I think this is something that would be disabled for default.

Since the cover allows custom radius the background would need custom one too

yes, but it could be done in a second step IMO.

When there is no image which color should it fallback to?

I would fallback to the current behaviour

What about the expanded representation? Should the widget use colors from the album when placed on the Desktop?

This in my opinion could be an other separate feature, I've been wanting to implement something similar to this for quite a while now. I was thinking to use the dominant color as background (with opacity < 1) and apply a fade effect to the album art, but I've never found an easy way to get the dominant color from the image, I didn't know about Kirigami.ImageColors!

StrongSand94191 commented 4 months ago

this looks amazing!

luisbocanegra commented 2 weeks ago

Added control for radius and animation for color change. Let me know what you think about these changes.

image

Screencast_20241115_014948.webm

StrongSand94191 commented 2 weeks ago

Added control for radius and animation for color change. Let me know what you think about these changes.

image Screencast_20241115_014948.webm

shouldnt the border extend a bit further to the left, past the album cover

luisbocanegra commented 2 weeks ago

shouldnt the border extend a bit further to the left, past the album cover

Yes, was waiting for https://github.com/ccatterina/plasmusic-toolbar/pull/149, will add it later today.

luisbocanegra commented 2 weeks ago

Ended up making the widget scale with the panel, now all sides have the same margin

Makes the tinted background look way better IMO:

Screencast_20241115_211046.webm