search

ccavanaugh / jgnash

jGnash Personal Finance
http://ccavanaugh.github.io/jgnash/
Other
139 stars 80 forks source link

Target accounts in OFX-Import of bank statement download #28

Closed Qaaqqo closed 7 years ago

Qaaqqo commented 7 years ago

Dear Craig,

thank you for this reliable and long-term software project!

To import my bank statement download, which is only available in some custom csv format, I want to convert these csv-files to ofx-files (with a custom python script) and then import the ofx-files into jgnash. With the newest version 2.32.0 I already can import the fields Date, Payee and Amount of ofx-files. But I fail to automatically set the Account field which determines the corresponding account for each transaction. In the OFX specification (version 2.1.1) in chapter 11.4.3 (Statement transaction) I found the BANKACCTTO-Tag and the CCACCTTO-Tag, which seems to be a possible tag for the target account information. But jgnash seems to ignore the Tag during import.

Do you have a hint what would be the best way to automatically set the target accout for each transaction? I would like to avoid to manually set each target account for each transaction during the import process.

Thank you very much! Daniel

ccavanaugh commented 7 years ago

As of right now, jGnash has the ability to learn the best account based on the memo and payee fields.

I have no issue with implementing use of the xACCTTO tags if a valid file for a unit test can be provided.

ccavanaugh commented 7 years ago

Daniel,

I am working on an xACCTTO tag implementation for the next release. I should be able to commit something in the next day or two for trial.

ccavanaugh commented 7 years ago

I have committed code that is working well for me based on what I could find of a proper example.

The Account Number in the Account Properties must be set to match the tag.

https://github.com/ccavanaugh/jgnash/blob/master/jgnash-convert/src/test/resources/bank2.ofx is the link to the test file.

ccavanaugh commented 7 years ago

Implemented for 2.33.1

Qaaqqo commented 6 years ago

Thanks for that implementation!

Sorry for the late response.

I tried version 2.33.1 with your test-ofx-file, I only changed the BANKID and the ACCTID for the first transaction to the corresponding values (Account Number and Bank ID) of one bank account in my jgnash accounts.

I can import both transactions of the test file but the proposed target accounts are not affected by the BANKACCTTO-Element in the ofx-file.

I use Linux with Oracle Java 8 and started jgnash with the shell script jgnash. (terminal output)

Here you find corresponding jgnash accounts and the ofx file: test.zip

Can you reproduce the problem? Or do I have to use it in a different way?

Best wishes Qaaqqo