search

ccavanaugh / jgnash

jGnash Personal Finance
http://ccavanaugh.github.io/jgnash/
Other
139 stars 80 forks source link

Checkbox to autocomplete the ending balance. Text needs localization. #36

Closed kumarpranay closed 6 years ago

kumarpranay commented 6 years ago

The statements for almost all my accounts do not come on month end. I need to reconcile on random dates which needs to manually type in the balance amount. This patch allows the reconcile dialog to pick the balances from the account for the date specified by user to reconcile on.

ccavanaugh commented 6 years ago

I've been playing with this and something seems off. With the current approach, the datePicker overwrites itself with the event handler call to handleUpdateBalance() essentially doing nothing.

I've reverted until I can better understand.

kumarpranay commented 6 years ago

My bad. I was trying to reuse the determineBalances() function which actually "predicts" the statement date and hence updates it.

I have a much more simplified patch now. Not sure the right you to request a merge. Create a new request?

ccavanaugh commented 6 years ago

An emailed diff or pull request would be just fine. thanks for fixing it.

--Craig

On Thu, Nov 9, 2017 at 10:07 AM, kumarpranay notifications@github.com wrote:

My bad. I was trying to reuse the determineBalances() function which actually "predicts" the statement date and hence updates it.

I have a much more simplified patch now. Not sure the right you to request a merge. Create a new request?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ccavanaugh/jgnash/pull/36#issuecomment-343182681, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm4ItRYMBZqXaZp1eDy6gNtqFv3rAFtks5s0xUVgaJpZM4QWjWt .

kumarpranay commented 6 years ago

Will create a new merge request.