search

ccavanaugh / jgnash

jGnash Personal Finance
http://ccavanaugh.github.io/jgnash/
Other
139 stars 80 forks source link

Exe launcher fails when JDK 11 is present #66

Closed valnaumov closed 5 years ago

valnaumov commented 5 years ago

Actual Behavior

jGnashFx.exe does not launch the app starting 2.35.0, although the bat script does.

Specifications

JDK 11.0.1 is also installed on the system. If I rename the JDK folder, it works. Could you point to what has changed in the packaging process in 2.35.0?

I hope to see a bundled JRE with the app with the comming of Java 9. I don't mind extra 100MB.

ccavanaugh commented 5 years ago

More than likely, its caused by JavaFx not being installed as it was separated in Java 11. Manual installation and running against the 3.0-dev branch should work.

The 3.0-dev branch is a work in process that will address this long term. I'm sorting out a new reporting interface to replace the old API rot caused by jasperreports and itext that is preventing migration to Java 11.

I do intend to have jGnash download the JavaFx dependency automatically because it's platform dependent. I'm not certain about bundling a JRE yet simply because I cannot build an OSX release at this time.

valnaumov commented 5 years ago

Manual installation and running against the 3.0-dev branch should work.

I hoped to run with JRE 8. Is there a way to tell launch4j to look for JRE 8, not JDK 11?

Are you targeting JDK 11 on 3.0-dev? What problems are you facing with bundling on OSX? Maybe I could help.

ccavanaugh commented 5 years ago

3.0.0 has been released

valnaumov commented 5 years ago

Great! That solved the issue!