search

ccavanaugh / jgnash

jGnash Personal Finance
http://ccavanaugh.github.io/jgnash/
Other
141 stars 79 forks source link

Move main class to new package: jgnash.app #88

Open msgilligan opened 5 years ago

msgilligan commented 5 years ago

This will help when/if we add support for JPMS.

ccavanaugh commented 5 years ago

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name. This was due to Java limitations at the time. I'm currently unable to test for proper behavior on macOS.

msgilligan commented 5 years ago

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name.

Is there something preventing us from moving jGnashFx into a package like jgnash.app?

I'm currently unable to test for proper behavior on macOS.

I'm a macOS user and it's also my main development platform, so (if I decide to stick with my current plans) I should be able to help with this a little.

ccavanaugh commented 4 years ago

I've been able to perform a bit of testing with OSX using a VM. It's not 100% The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed. It doesn't impair function, so I'm okay as is.

Screenshot from 2020-02-10 19-07-57

http://bekwam.blogspot.com/2015/11/mac-menus-in-javafx-app.html provides a potential workaround. I think a variation that targets OSX only is workable until JavaFX improves integration.

msgilligan commented 4 years ago

The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed.

Take a look at NSMenuFX -- I've used it successfully in the past and it is being updated for newer Java lately (there's a 2.1.7 release that isn't listed on the site)