Open gapisback opened 4 months ago
Hi, @rgerganov @yelvmw -- can you help give this issue a fresh look?
This is a brand-new failure happening in CI when I started a PR to merge some doc-changes. Before I do some deep-dive investigation, would like a quick cross-check from your Linux env.
From my initial investigation, it appears that some Linux system / headers interfaces have changed.
If you have an active Linux-VM on which this CFCC repo was building correctly before, can you please try the following out and let me know how it works?
(Cut-n-paste your outputs here as a reply, so it's publicly visible.)
cd ./sev-snp-simulator
make
This used to build just fine previously.
If you run into an error that /bin/sh: 1: gcc-12: not found
, I "worked-around it" by installing gcc-12, as: sudo apt-get install -y gcc-12
.
But I am not sure why that should even be necessary.
History: The last successful PR that was merged into this repo was in Dec 2023 (PR #232), after which this repo was moved to CCC's ci-infra.
So, that might be one cause for the drift in Linux rev-levels, triggering some build issue.
Looks like a kernel 6.4 change to API. We might want to try this:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 4, 0)
sev_class = class_create(THIS_MODULE, DEVICE_NAME);
+#else
+ sev_class = class_create(DEVICE_NAME);
+#endif
I'm actually not sure about the exact version. Got some hints from discussions elsewhere. Can you confirm the CI environment kernel version?
Thanks for the tip, @yelvmw, that looks promising. -- I'll work on this after Sangwan checks-in his Islet-cleanup PR.
Will let you know what I find out about Linux kernel version.
CI Job for PR #241 fails with following hard error:
CI's build.yml specifies:
runs-on: ubuntu-latest
I am able to reproduce this on my Linux-VM running: Ubuntu 22.04.4 LTS jammy
Somethings seem to have changed in Linux system / include files. By default, if you do the following:
This will fail with:
Fix this by installing gcc-12 (for whatever reasons):
$ sudo apt-get install -y gcc-12
Upon re-run this
make
command now fails with the same signature of failure as seen in CI job: