tanjeff
commented
13 years ago The date is shown on the Mateka'te when the '+' sign in the upper right corner is "opened". It specifies the time at which the last update was fetched from the OSM server. Here is how it works.
Consider the file machMateKate.rb (version 650083c0ad):
- Line 193 (in parse()): The variable date is set.
- Line 196: (in parse()): date is being returned (together with count).
- Lines 211 and 226: parse() is called, once for the club-mate points and once for the afri-cola points. The received dates are stored in the global variables _$date_drink_clubmate and _$date_drink_africola respectively.
- Lines 249 - 267: The HTML code is generated by copying the contents from infile to outfile line by line. During this process, the _$date_drink_clubmate and _$date_drink_africola values are inserted (only if the respective patterns are found in infile, of course).
The update date was originally read from the OSM files (which contain XML data). This has advantages when the download of new data fails for some reason - the old script simply used the older files which were still there. In this case, the date in each file indicated how old the respective data was.
If the date is not longer part of these files, it should be removed. It would be useless to know when the script ran the last time. Only the real age of the OSM data is of interest.
The old script used to parse a date from the downloaded XML. In the new API, this date no longer exists so for now we replaced it with a static string. But it looks like the date is not used in the rest of the script anyhow so it should be removed all together. But first we should find out what was the intention behind this.