search

cccs-web / core

CCCS' customized django web application
4 stars 11 forks source link

What is src/mezzanine-slides for? #127

Closed pwhipp closed 9 years ago

pwhipp commented 9 years ago

Can you put messages with all commits please?

cccs-ip commented 9 years ago

Thanks for the reminder, Paul. Cristi - This is a "good practice" suggestion in all cases, but I assume Paul is asking b/c you pushed to branch 'master' (as opposed to branch 'css')?

Please continue to work on branch 'css' until we're ready to merge it into master. Please also try to stay current with branch 'master' as you work.

Thanks!

Cristialt commented 9 years ago

hi, I do that

src/mezzanine-sldes is something I've found when merging master into css , and didn't know how to call it, I actually wanted to ask you the same thing. I am guessing it's a slider coponent from mezzanine, but don't think we need itsince a foundation based one is already prepared. I'll lookk into it now, I am in a break, cut my finger waiting the bleeding to stop :warning: Thanks

Cristialt commented 9 years ago

OK, it will be simple to connect it to the Foundation stuff if you say it's better to use it as a Django compoent

pwhipp commented 9 years ago

Sliders abound. I don't mind which one we use but you need to liaise with Aaron and Marcus - they use them. They need to be happy with the administration and presentation of any alternative.

aaronkyle commented 9 years ago

Orbit slider will be depreciated on Foundation 5 : http://foundation.zurb.com/docs/components/orbit.html

Cristialt commented 9 years ago

That's form F6, it's now part of the framework (on v5.x). That's why I decided to use it, because when the F6 will be released we could choose the best option at that time *(maybe keeping orbit, maybe switching to another slider etc)

cccs-ip commented 9 years ago

By the way, did we answer this question? My reading is that Cristi found a slider component when merging branch css into master, and decided to name it something within his build b/c it overlapped with a component imported from Foundation. Is this correct? Does this issue need to stay open?

Cristialt commented 9 years ago

It didn't overlap anything, however, I don't know what's that for atm, but it can be used when needed, for now it's just there as we don't have yet a place and content for it. And I think this can be closed

pwhipp commented 9 years ago

I've removed it from master. In the unlikely event that this causes a problem we can put it back. I'm not aware of the module needing it and I suspect that it was an artifact of a local build or installation of the module.