Closed pwhipp closed 10 years ago
I see this as an issue with making these fields markdown so they can be properly formatted. The same is true of the 'description' which should really be called 'content' for consistency with pages etc. (my bad):
The cv 'description' was really intended for the html page description. I've fixed it for this purpose and added a correct 'content' field which is for the cv content. The description is generated automatically from the content by default. This makes it consistent with pages and other site content.
I've applied these changes to production your review because I think they are a good improvement.
Note that the pagedown alignment problem is in a separate issue (#140)
Close this issue if you are happy with these fields now being markdown so they can be formatted properly - They should work, even though the preview is failing.
I am not seeing the fix:
Am I missing something?
I see where you added the 'content' field, and your backend improvements to the CV look good. They are not, however, showing on the front end.
Also, the term 'content' isn't terrible descriptive. It should read something like 'Summary Profile' or 'Biographical Profile'. Similarly, to avoid confusion, 'Description' should be called 'HTML Page Description'. I will add these to #110
I'm inheriting the mezzanine content/description fields to make use of its Displayable built in capabilities for the page keywords, draft/published...
Overlaying alternative names for these fields may be tricky and could lead to long term confusion with other mezzanine extensions.
There is a problem that I've hastily deployed to production - #142
Sorry - I really should have been deploying to staging. Will go back to that process after dealing with the urgent issues.
I mistakenly assumed that pagedown handled any RichText field. I've extended it with a very simple mkdown app which does the job so this is all working now.
Deployed straight to production ... will I ever learn? ;) The trouble with staging is that I'm submitting too many changes too fast at the moment so I'll reserve it for anything dubious (such as upgrades, significant migrations...)
your fix looks beautiful, thank you!
With regard to the 'Projects' section, the main problem I see is how the database text is presented. My list of activities, for example, isn't breaking at all:
* facilitating project planning and reporting to meet IFC requirements * lead author of the Project Code of Conduct (CoC) * co-author of the Public Consultation and Disclosure Plan (PCDP) * coordinating editor and lead reviewer of the Cultural Heritage Screening Report * lead author of the Cultural Heritage Protection Plan (CHPP) * contributing author to the Community and Indigenous Peoples Development Plan * contributing author to the Land Acquisition and Resettlement Plan (LARAP)
Finally, there is no value in the 'references section', yet this field is still showing. You suggested it would be possible to hide headers and field areas if there was no content available?