Front end editing no longer working on staging

[pwhipp]

As of a69d284 the yellow tags on the front end page are not showing on staging.

[pwhipp]

The correct form is being generated and hidden.

the markdown stuff looks like it is breaking the javascript used to present the edit tags.

[cccs-ip]

Should we bother going further with this or leave it?

[pwhipp]

hyphens should not be present in the variable name. There is a token being added naively (presumably as a cheap way to avoid namespace issues with javascript) that is resulting in the syntax error.

...lib/python2.7/site-packages/mezzanine_pagedown/templates/mezzanine_pagedown/editor.html

references an id directly to create the offending value.

The id is the problem when used in this context because its hyphens are breaking the javascript.

https://bitbucket.org/akhayyat/mezzanine-pagedown/issue/11/widget-template-id-unexpected-token

The fix_dashes branch of the code is only at version 0.5 which breaks on missing templates.

I'm going to have to create our own 'fork' to deal with this.

[cccs-ip]

Thanks for dealing with this. Will these sorted of fixes ever make it upstream, or must one sort through all the forks? You found this fix using Google, as opposed to reading about various forks? Seems matters should be easier or more integrated.... On 28 Jul 2014 09:45, "Paul Whipp" notifications@github.com wrote:

hyphens should not be present in the variable name. There is a token being added naively (presumably as a cheap way to avoid namespace issues with javascript) that is resulting in the syntax error.

...lib/python2.7/site-packages/mezzanine_pagedown/templates/mezzanine_pagedown/editor.html

references an id directly to create the offending value.

The id is the problem when used in this context because its hyphens are breaking the javascript.

https://bitbucket.org/akhayyat/mezzanine-pagedown/issue/11/widget-template-id-unexpected-token

The fix_dashes branch of the code is only at version 0.5 which breaks on missing templates.

I'm going to have to create our own 'fork' to deal with this.

— Reply to this email directly or view it on GitHub https://github.com/cccs-web/core/issues/84#issuecomment-50308631.

[pwhipp]

Cristi - am I right in thinking that this causes issues for you because it is messing up the javascript processing?

[pwhipp]

This should help

[Cristialt]

Can I have a link for this issue please? I have seen no Javascript error , couldn't find any page causing conflicts

[pwhipp]

https://staging.crossculturalconsult.com/

username: cccs, password: letmein (not for security - just to prevent bots/casual visits)

Just use dev tools in your browser and you will see the error in the console.

I know what is causing it (mezzaine_pagedown). I want to know if it is causing other problems such as this issue.

[pwhipp]

btw - remember that if you put an issue into somebody else's hands, you should assign it to them.

[pwhipp]

The javascript issue has been corrected but front end editing is still not appearing. It needs to be fixed.

[cccs-ip]

Thanks, Paul. Annoying, but not a functional barrier. Let's investigate as you have time.

[cccs-ip]

It would be good to figure this out. We'll be working on more on page content soon, and it'd be handy not to have to work through admin all the time.

[pwhipp]

OK... there are some horrid javascript interactions going on between Mezzanine's edit and the pagedown stuff.

I experimented and have managed to get a load order sorted that seems to work. I had to change the line height styling for the preview paragraph (mezzanine was making it zero for some reason) and the jquery is being loaded twice (Mezzanine insists on loading it even though I load it up front) so I'm not happy with this but could end up burning a lot of time trying to sort it out (Javascript :().

Try it out in staging - it seems to work OK in spite of the double jquery load so I think this is fixed.

[pwhipp]

Only in staging at the moment though.

[cccs-ip]

Thanks, Paul. It is a big clunky-looking still, but it works - which is the main point. The overall staging theme continues to grow on me too, though there is clearly a lot of work ahead in order to fix it up....