search

cccssw / xxhash

Automatically exported from code.google.com/p/xxhash
Other
0 stars 0 forks source link

Defining basic types #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hey, I have a problem to compile a r28 with my ruby gem 
(https://github.com/nashby/xxhash). Here is an error:

compiling ../../../../ext/xxhash/libxxhash.c ../../../../ext/xxhash/libxxhash.c:111:15: error: unknown type name 'U32' static inline U32 XXH_swap32 (U32 x) { ^ ../../../../ext/xxhash/libxxhash.c:111:31: error: unknown type name 'U32' static inline U32 XXH_swap32 (U32 x) {


if I move definition of the basic types before XXH_swap32 function everything 
works. Am I doing something wrong here?

Thanks!

Original issue reported on code.google.com by YouN...@gmail.com on 15 May 2013 at 5:37

GoogleCodeExporter commented 9 years ago 
uhoh, this is completely right. Thanks for pointing that out.
At first I was surprised that none of my compilers grabbed the issue, but then, 
I realised that neither Visual nor GCC v4+ is using this code branch.

Original comment by yann.col...@gmail.com on 15 May 2013 at 7:24

GoogleCodeExporter commented 9 years ago 
The following release candidate (attached file) is supposed to solve the issue 
by using your proposed solution.

Original comment by yann.col...@gmail.com on 15 May 2013 at 7:29

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks, everything works as expected with this RC. BTW, do you mind to bring in 
versioning for xxhash? What do you think about it?

Original comment by YouN...@gmail.com on 15 May 2013 at 7:36

GoogleCodeExporter commented 9 years ago 
Bring in versioning ? I'm not sure to understand, could you please explain ?

Original comment by yann.col...@gmail.com on 15 May 2013 at 8:18

GoogleCodeExporter commented 9 years ago 
Sorry, I mean to tag current code with some version (sorry, I'm speaking in 
terms of git here http://git-scm.com/book/en/Git-Basics-Tagging and not sure 
how it does with SVN) and release new version further so I can release a new 
version of ruby gem when you're releasing a new version of xxhash.

Original comment by YouN...@gmail.com on 15 May 2013 at 8:35

GoogleCodeExporter commented 9 years ago 
Ah sorry, I don't know how it works.
I guess what you are requesting is achievable using Git, but I'm unaware if 
it's possible to do the same with SVN.

Original comment by yann.col...@gmail.com on 15 May 2013 at 8:40

GoogleCodeExporter commented 9 years ago 
Issue corrected into r29

Original comment by yann.col...@gmail.com on 16 May 2013 at 7:09