search

ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
988 stars 135 forks source link

Filters do not work #122

Closed TicTac9k1 closed 10 years ago

TicTac9k1 commented 10 years ago

They just don't. Even when applying a rule made via the menu dropdown filter box.

TicTac9k1 commented 10 years ago

I imported mine as they were from appchan, where this worked fine. No clue why it does not now. http://i.imgur.com/jYGdzVZ.png

ccd0 commented 10 years ago

At the moment, only 4chan's filters work in the catalog, but I'll see what I can do.

ccd0 commented 10 years ago

I looked at implementing 4chan X filters in the native catalog. Unfortunately it doesn't have all the data necessary to make all the filters work, so for full filter functionality you'd have to delay loading until catalog.json was finished downloading. And if you do that, there's not much advantage over just rebuilding the catalog. And even partial filtering (filters on some fields not working) would be glitchy and hard to maintain.

I've added a port of Mayhem's catalog to the beta version, and all 4chan X filters should be working in it. The native catalog can still be used for those who prefer it, but I probably won't be adding many features to it.

ccd0 commented 10 years ago

Are filters working for you now?

TicTac9k1 commented 10 years ago

Ah, I could test it. I haven't gone to 4chan ever since the whole censorship bullshit. Kind of ironic when requesting a feature like this and talk about censorship but at least i'll be in control what I'm filtering. :^)

Tested it, filters work in non-catalog mode, but threads are still visible in catalog.

Actually scratch that, a full refresh was needed for the filters to be in effect. Yeah, it works.