search

ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
988 stars 135 forks source link

Keybinds seem to have stopped working #2216

Closed ccd0 closed 1 year ago

ccd0 commented 5 years ago

Submitter: Anon Email: anon@gmail.com I reset the settings after I discovered the error, and keybinds still don't seem to work.

ccd0 commented 5 years ago

They're working for me. What version, browser, and userscript engine are you on?

Bebop79 commented 5 years ago

Same issue on Firefox Quantum 64.0.2 with the latest version of Tampermonkey Just noticed I was using an old version(1.14.4.7) so I updated to the newest one from a few hours ago(v 1.14.5.11) and I still have the same problem

philfry commented 5 years ago

Same here. Console sez:

TypeError: String.fromCharCode(...) is undefined[Learn More] b:18102:22
keyCode/key< https://boards.4chan.org/b/:18102:22
keyCode https://boards.4chan.org/b/:18073:14
keydown https://boards.4chan.org/b/:17717:19

4chan-x 1.14.5.11 and lower firefox 64.0.2 (on Fedora 29) ublock origin 1.18.2 umatrix 1.3.16

ccd0 commented 5 years ago

Try going to your uBlock Origin settings under Filter Lists, then clicking "Purge all caches" and "Update now"

philfry commented 5 years ago

thanks, but that didn't help.

ccd0 commented 5 years ago

Can you reproduce the problem without any other extensions running?

philfry commented 5 years ago

No. I created a new firefox profile, installed violentmonkey and 4chan-x only, and everything works fine. I'll add the other extensions and try to figure out what kills 4chan-x' keybindings.

philfry commented 5 years ago

I think the problem is in the ublock filters around line 1870:

4chan.org##+js(abort-current-inline-script.js, String.fromCharCode, /\/\*[0-9a-f]{40}\*\//)

When adding a custom filter overriding this one the keybindings work again:

4chan.org##+js(abort-current-inline-script.js, String.fromCharCode, /\/\*[0-9a-f]{40}\*\//)$badfilter
ccd0 commented 5 years ago

That filter should have been removed. https://github.com/uBlockOrigin/uAssets/commit/a1eeaa31dfb44061024f3681b1cb107f690e946e Are you sure your filter list is up to date?

philfry commented 5 years ago

I purged the cache and did an update. The filter at line 1870 is still present. The patch you're referring to regards a different filter.