ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
980 stars 134 forks source link

4chan claiming the captcha wasn't completed (was: Performance Issues) #2452

Open CharAznableLoNZ opened 5 years ago

CharAznableLoNZ commented 5 years ago

The last few version now have exhibited performance issues. Hovered images will stay hovered, I'm not sure where the issue lies or if it's even 4chanX related. I see performance issues on 4channel but not on 4chan boards. Chrome 78.0.3904.44 Tampermonkey 4.8.41 4ChanX 1.14.14.4

CharAznableLoNZ commented 4 years ago

If I was venturing a guess, I'd say garbage cleanup is not occuring as often as it should. It seems the process hits about 5GB of RAM usage and starts to choke. When cleanup does occur and the RAM usage drops down, all 4channel tabs are much more responsive.

CharAznableLoNZ commented 4 years ago

I've also noticed thanks to this lag, even though the captcha is solved, posts cannot be completed due to captcha "not being solved". It just spams the error again and again until it finally realizes, yes the captcha was solved a minute ago.

CharAznableLoNZ commented 4 years ago

It just spams this over and over again despite the captcha having been solved a minute ago and the captcha count at 1. Screenshot_20191028_042247 If you let it spam that for about 10 minutes eventually it'll post.

CharAznableLoNZ commented 4 years ago

Bumping that the error above with the script claiming the captcha wasn't completed is still occurring despite much lower system resources being used and the captcha being completed several times.

CharAznableLoNZ commented 4 years ago

This is becoming horrendous and making the script nearly unusable. One has to spam the enter for 20+ seconds before it will just post. I've tried solving multiple captchas, all of which were accepted however the post does not go through and just sits on the above error. Spamming space or enter until it posts seems to be the only way to get around it.

ccd0 commented 4 years ago

Check in the network tab of your browser's console that it's actually sending a captcha token with the post. If not, there's a bug on 4chan X's end to be fixed. If the token is being sent, there's not much I can do about 4chan rejecting it.

CharAznableLoNZ commented 4 years ago

I"ll check the next time it does it.

CharAznableLoNZ commented 4 years ago

Here is it doing it again;

Request URL: https://sys.4channel.org/o/post Request Method: POST Status Code: 200 OK Remote Address: 104.17.78.75:443 Referrer Policy: origin Access-Control-Allow-Credentials: true Access-Control-Allow-Headers: If-Modified-Since Access-Control-Allow-Methods: GET, OPTIONS Access-Control-Allow-Origin: https://boards.4channel.org Access-Control-Max-Age: 1728000 Cache-Control: private, no-cache, must-revalidate CF-Cache-Status: DYNAMIC CF-RAY: 58c6bf8f0ed0e36a-SEA cf-request-id: 0270160d690000e36ad9bae200000001 Connection: keep-alive Content-Encoding: br Content-Security-Policy: upgrade-insecure-requests Content-Type: text/html; charset=UTF-8 Date: Fri, 01 May 2020 04:27:08 GMT Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct" Expires: -1 Server: cloudflare Set-Cookie: __cfduid=de93e456b59a2b2183c11a499a774f0bc1588307228; expires=Sun, 31-May-20 04:27:08 GMT; path=/; domain=.4channel.org; HttpOnly; SameSite=Lax; Secure Strict-Transport-Security: max-age=15768000 Transfer-Encoding: chunked Vary: Accept-Encoding Vary: Origin, Accept-Encoding Accept: / Accept-Encoding: gzip, deflate, br Accept-Language: en-US,en;q=0.9,en-GB;q=0.8 Connection: keep-alive Content-Length: 620 Content-Type: multipart/form-data; boundary=----WebKitFormBoundary2ihGw5n62Maq5dLs DNT: 1 Host: sys.4channel.org Origin: https://boards.4channel.org Referer: https://boards.4channel.org/ Sec-Fetch-Dest: empty Sec-Fetch-Mode: cors Sec-Fetch-Site: same-site User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.34 Safari/537.36 resto: 22302077 com: >>22302077 I wait a couple minute or so then start out being very gentle.
mode: regist pwd: Ab3jhNN-dmGcEJQH0cmyQn40pKteNKSrXjSkq140pKteJfy3IusTIpUDpSUqu3l6NbicVjySMfU0XGnXOaIykFITpuxqrImc_c_QvT1TYvciiXdm8D7QF_2-UzB3

ccd0 commented 4 years ago

Do you have any extensions that might interfere with cookies being sent to 4chan?

Alternately, are you shift-clicking on submit? I noticed a bug related to that when reviewing the code.

CharAznableLoNZ commented 4 years ago

I do have umatrix installed, that would be what I would expect to interfere. With mootwo's doings lately I try to let as little run from the site as possible. When I submit, I use the numpad to select the tiles then hit enter when done.

Screenshot_20200509_165515

ccd0 commented 4 years ago

That would probably be it. When you successfully post with a captcha, 4chan sets a cookie allowing you to make subsequent posts without a captcha for a limited time. If 4chan X detects the cookie is set, it will not send a captcha. Unfortunately uMatrix cookie blocking doesn't prevent the cookie from being set, only from being returned to 4chan:

https://github.com/gorhill/uMatrix/wiki/Cookies

Blacklisted cookies are not prevented by uMatrix from entering your browser. However they are prevented from leaving your browser[1], which is what really matters.

The way to fix this would be to either allow cookies to be sent to 4chan (possibly selectively), or block cookies from 4chan in a different way so that they are not set rather than just not sent.

Let's keep this open for now to inform others and in case someone thinks of a good way to detect this situation.