search

ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
967 stars 132 forks source link

Too many threads on a page? #265

Closed ghost closed 9 years ago

ghost commented 9 years ago

I'm not sure what this issue is. I'm not sure how to describe it, or what you'd even call it. I'm not even 100% sure on how to reproduce it. I've noticed it happens often on boards with stickies (/g/) but not always. Basically, I'll use CTRL+Up or CTRL+Down to navigate through threads, and then use Shift+O to open them in a new tab. Sometimes, it opens the second to last thread on the page instead of the last thread on the page, even the last one is the selected one. Heads up, slightly NSFW, /t/: http://a.pomf.se/zdnypr.mp4

ghost commented 9 years ago

Another example, this time on /g/. http://a.pomf.se/uvktml.mp4 Still don't know what's causing it, so I can't really tell you what steps to take to reproduce. Sorry. I just know that this isn't the first time I've had this issue. It isn't exactly an issue, per se, it's just something that annoys me.

ghost commented 9 years ago

An example on /biz/ http://a.pomf.se/jaiqit.mp4

ccd0 commented 9 years ago

It seems the thread navigation code doesn't actually track which thread you've selected, but just goes by your scroll position on the page. So if the bottommost thread is too short, it will open the next-to-bottommost.

ghost commented 9 years ago

Alright, thanks. At least you know what the issue is, I couldn't even figure that part out.

ccd0 commented 9 years ago

Alright, as of v1.9.18.6 the thread navigation keybinds will add space to the bottom of the page if necessary to select the last few threads.

ghost commented 9 years ago

It's not exactly pretty, but it works. screenshot-7 Thanks for the quick fix, as usual.