search

ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
986 stars 135 forks source link

Performance - Intersection Observer? #2935

Open saxamaphone69 opened 3 years ago

saxamaphone69 commented 3 years ago

In the event that the minimum version of Firefox/Chrome get bumped up, I would assume that 4chan X could use IntersectionObservers to detect elements within the viewport or otherwise.

The relatively recent blog post on the performance of the new GitHub home page reminded me of that time I was trying to determine the negative reflow/render effects on elements when applying my userstyle.

~I've also noticed that default 4chan has added the lazyload attribute to thumbnails. Not sure if the benefits would still work on elements rendered by 4chan X in a userscript manager.~ This got done, nevermind.

paradox460 commented 1 year ago

This would help with what >>91904180 is requesting:

Can you add a setting for Linkify so that it only changes links when it's in view instead of trying to change them all when you load a thread?

ccd0 commented 1 year ago

Looks very helpful. For older browsers, we could write a polyfill. It wouldn't necessarily have to be a complete polyfill that does everything IntersectionObserver does, just the stuff we are using in the script. It might take the form of one or more utility functions that use IntersectionObserver if it's available, and do it the old way otherwise.

ccd0 commented 1 year ago

Although since Firefox v55 is already pretty old, it might just be easier to drop support for versions older that it. We should check whether it made it into the various Firefox forks people use.

saxamaphone69 commented 1 year ago

Both WaterFox and PaleMoon added support in 2019 by the looks of it FWIW. Not sure which other "major" Firefox forks are out there that are worth worrying about.

You know me and how I feel about bumping the minimum browser version (all for it).

ccd0 commented 1 year ago

If that's the case, it should be safe to bump the minimum version as soon as someone writes the code for this, although if it happens before the Javascript rewrite is finished we may want to delay the release to combine it with that. If we get any complaints then we can look into polyfills.