ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
984 stars 135 forks source link

No html in board title/subtitle #297

Closed bakugo closed 9 years ago

bakugo commented 9 years ago

Don't know if this is intended, but 4chan X removes html tags from board titles/subtitles.

Without 4chan X: image

With 4chan X: image

ghost commented 9 years ago

works on my machine :^) screenshot Shitposting aside, this is probably related to the release of https://github.com/ccd0/4chan-x/blob/master/CHANGELOG.md#v1737

Disable HTML both in custom board titles and file info formatting. This shuts down a means for a malicious script injected into the page to permanently install itself, to be run each time you browse 4chan. I expect few or no people were actually using their own HTML in these fields; if you want it back, make a request on the issues page, and I will consider working on a secure implementation.

ghost commented 9 years ago

Disregard that, I suck cocks. It looks normal in the index, but I get the same thing you do in threads. screenshot-1

bakugo commented 9 years ago

Yeah, I guessed it was for security purposes, but it would be nice to be able to keep html only for non-custom titles since moot sometimes plays around with them (rip).

ghost commented 9 years ago

I'm pretty sure these are the related commits. https://github.com/ccd0/4chan-x/commit/6ce8bef70945d7ef8bcbbd9a0fa7053c41158cb9 https://github.com/ccd0/4chan-x/commit/0415828e271476e201b883d5054e6ca55ed74444

ghost commented 9 years ago

That was fast.

bakugo commented 9 years ago

Yep. Thanks.