ccd0 / 4chan-x

Adds various features to anonymous imageboards.
https://www.4chan-x.net/
Other
980 stars 132 forks source link

Add a Werk/Fappe Tyme indicator #70

Closed iiiGerardoiii closed 9 years ago

iiiGerardoiii commented 10 years ago

It would be great to have an indicator that only shows up when you have Werk or Fappe Tyme enabled. People might forget it's enabled.

e.g. captura de pantalla 2014-05-24 08 292

ccd0 commented 9 years ago

Is there any need to have Fappe Type remembered at all when you navigate between pages?

iiiGerardoiii commented 9 years ago

Fappe Tyme gets confusing/annoying if you have multiple tabs with threads open, because if you enable fappe tyme on one thread, the rest of the tabs won't have it enabled until you refresh them. But it's not like you wanted the rest of threads to have fappe tyme enabled anyways. Example: http://a.pomf.se/cfstnr.mp4

Suggestion: Enabling Fappe Tyme on a thread will only work on that selected tab, the rest of the tabs will keep fappetyme disabled even if you refresh them.

ccd0 commented 9 years ago

What about Werk Tyme? To me it would make sense for Werk Tyme to change all the tabs, and for Fappe Tyme to only change the tab you set it on, and only while you stay in that thread.

Werk Tyme I would think is obvious enough most of the time that it doesn't need an indicator, although I suppose you could forget you had it on in a long thread. I think it's also been less of a problem because the default keybind is harder to trigger by accident (shift+w versus plain f).

iiiGerardoiii commented 9 years ago

I agree, Werk Tyme should keep changing all the tabs, and it doesn't really need an indicator because you can still see the filenames on the posts so you go "oh, there's a hidden pic in this post ok"; With fappe tyme this doesn't happen, you can't see a hint of the hidden posts, they just disappear, hence forgetting it was enabled. So I thought of these 2 fixes, they might work or not, you be the judge.

1- If FappeTyme enabled, the border of the header turns to a vivid color, to make the user remember he's in fappe tyme mode, but maybe it's too much and the tiny icon is enough? This zip has images with a few ideas: http://a.pomf.se/qdudkp.zip

2- (This one won't need an indicator.) If FappeTyme enabled, make stubs of the posts that got hidden (be able to read them on mouseover would be nice). The user won't forget it's enabled because he'll see the stubs through the thread. Example: http://a.pomf.se/aiawaf.gif

ccd0 commented 9 years ago

Not sure if we still need an indicator now that Fappe Tyme is non-persistent. Thoughts?

iiiGerardoiii commented 9 years ago

I think Fappe Tyme being non-persistent is good enough, thanks!