Skip verify ssl doesn't work

ccfos / nightingale

An all-in-one observability solution which aims to combine the advantages of Prometheus and Grafana. It manages alert rules and visualizes metrics, logs, traces in a beautiful web UI.

https://flashcat.cloud/docs/

Apache License 2.0

9.42k stars 1.38k forks source link

Skip verify ssl doesn't work #2028

Closed chenyunda218 closed 1 month ago

chenyunda218 commented 1 month ago

我發現回調地址中的"跳過SSL驗證" 不起作用，並且在nightingale/alert/sender/webhook.go 中的 sendWebhook 中有一個// todo add skip verify。有甚麼特殊原因不去實現該功能嗎？如果沒有特別的原因我願意去實現該功能。

710leo commented 1 month ago

@chenyunda218 没有特殊原因，应该是当时开发的时候，漏掉了，欢迎提 PR 实现。